Draft
Conversation
add source_url and license information
henrysky
reviewed
Feb 23, 2026
Owner
henrysky
left a comment
henrysky
left a comment
There was a problem hiding this comment.
Thanks for the PR to get the work started.
- The motivation of having the Sun on the right hand side (instead of at the bottom for the new map or left hand side) is to be consistent with astropy and (galpy)[https://github.com/jobovy/galpy], which by default put the Sun at galactocentic (x, y) = (8.xx, 0.0). For the new maps while it is straight forward to rotate the unannotated map, I Don't think we can just rotate the annotated map because some texts would be inverted. But I think it would be great to keep the sun on the right hand side unless the community disagree with it.
- We should include only high res images (question: how big are the high res version?). As one can generate a low-res version from the high res one locally on user's machines. For example with matplotlib, users can specify resolution in matplotlib instead of in this package. But I agree we can add options for user to specify resolution in this package too.
- Coordinates, scale, size of the face-on maps are currently hardcoded at here: since we only have one version of face-on map currently. Since we are going to multiple face-on maps, then we should make coordinates, scale, size etc properties of images like you did for copyright and license. Coordinates and scale are only relevant to face-on map (so keep those properties to
milkyway_plot/src/mw_plot/base.py
Line 385 in e104ced
MWPlotBase) because edge-on map should always covers the whole sky, coordinates at each pixles of edge-on map can be inferred.
Author
|
Thanks @henrysky for the responses. Please find below my inputs:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first attempt at adding the Gaia Milky Way maps (https://www.esa.int/ESA_Multimedia/Images/2025/01/The_best_Milky_Way_map_by_Gaia) to this package.
This PR should be considered a draft only, since it changes the default behaviour and does not allow the user to choose which map to plot.
It introduces the following changes:
Several aspects have not yet been addressed:
In my view, the goal would be to allow the user to choose between a range of face-on maps (Hurt, Gaia, annotated, not-annotated, etc.) and introduce the Gaia edge-on maps (https://www.esa.int/ESA_Multimedia/Images/2025/01/The_best_Milky_Way_map_by_Gaia_edge-on, https://www.esa.int/ESA_Multimedia/Images/2016/09/Anatomy_of_the_Milky_Way). Some of these are available in low- and high-resolution.
To implement this, I suspect that some deeper changes in the classes may be needed so that image properties (coordinate system, origin, size, resolution, etc.) are associated within
MWPlotCommonand then propagated as needed.